StumpWM Manual: 18.4 Sending Patches

[ < ]

[ > ]

[ << ]

[ Up ]

[ >> ]

[Top]

[Contents]

[Index]

[ ? ]

18.4 Sending Patches

While patches are still welcome on the mailing list, StumpWM’s development has mostly migrated to github’s issue tracker. This means you can open a pull request to submit a patch to StumpWM. The following guidelines apply to pull requests and patches sent to the mailing list.

Make sure it applies clean to the main git repository
Ensure that you aren’t introducing tabs, extra blank lines, or whitespace at the end of lines.
Ensure your patch doesn’t contain irrelevant indenting or reformatting changes.
Try to make your patch address a single issue. If your patch changes two unrelated issues, break them into two seperate patches that can stand on their own.
Don’t send intermediate patches. When you’re working on a feature you might make several commits to your local repository as you refine it and work out the bugs. When it’s polished and ready to ship, send it as one patch! Sometimes it makes sense to send it as multiple patches if each patch contains a discrete feature or bug fix that can stand on its own. If one of your patches changes code that was added or modified in an earlier patch, consider merging them together and sending them as one.